Skip to content

Add RHEL 9.2 variant #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 8 commits into from
Jan 31, 2023
Merged

Add RHEL 9.2 variant #1127

openshift-merge-robot merged 8 commits into from
Jan 31, 2023

Conversation

@travier
Copy link
Member

@travier travier commented Jan 27, 2023

c9s: Restore okd-copr repo by default for c9s

EL9: Move C9S overlay to the EL9 shared manifest

Will be used by the RHEL 9.2 variant.

Add RHEL 9.2 variant and set it as default for rhel-coreos-9

9.2: Add temporary COPR repo for openvswitch on s390x

See: https://lists.centos.org/pipermail/centos-devel/2023-January/142752.html

@travier travier mentioned this pull request Jan 27, 2023
Closed
@travier
Copy link
Member Author

travier commented Jan 27, 2023

Will need openshift/release changes for CI.

@travier travier mentioned this pull request Jan 27, 2023
Merged
@openshift-ci openshift-ci bot requested review from aaradhak and marmijo January 27, 2023 17:20
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@travier travier force-pushed the rhel-9.2-variant branch 2 times, most recently from aaf37a3 to 111c8c3 Compare January 27, 2023 17:26
@travier travier mentioned this pull request Jan 27, 2023
Merged
@travier
Copy link
Member Author

travier commented Jan 27, 2023

See: openshift/release#35789

cgwalters
cgwalters approved these changes Jan 30, 2023
View reviewed changes
manifest-rhel-9.2.yaml

arch-include:
s390x:
# Temporary repo for openvswitch on s390x
Copy link
Member

@cgwalters cgwalters Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only shipping a particular package on a particular architecture is going to trip up ART's consistentency checks; we should use the same content across all arches.

Copy link
Member Author

@travier travier Jan 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the same package that is included in all other arches but just a build for this arch. From #1126

manifest-rhel-9.2.yaml
#!/usr/bin/env bash
set -xeo pipefail
# Tweak /usr/lib/os-release
Copy link
Member

@cgwalters cgwalters Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not a new problem but we should factor this out into a common include)

@travier
Copy link
Member Author

travier commented Jan 30, 2023

Pushed an update that should build this 9.2 variant via the 9.0 Prow jobs so that we can test this in CI.

@cgwalters
Copy link
Member

cgwalters commented Jan 30, 2023 

 16:48:35 qemu0 kola-runext-rootless-systemd[1956]: Errors during downloading metadata for repository 'fedora':
Jan 30 16:48:35 qemu0 kola-runext-rootless-systemd[1956]:   - Curl error (6): Couldn't resolve host name for https://mirrors.fedoraproject.org/metalink?repo=fedora-37&arch=x86_64&countme=1 [getaddrinfo() thread failed to start]
Jan 30 16:48:35 qemu0 kola-runext-rootless-systemd[1956]:   - Curl error (6): Couldn't resolve host name for https://mirrors.fedoraproject.org/metalink?repo=fedora-37&arch=x86_64 [getaddrinfo() thread failed to start]
Jan 30 16:48:35 qemu0 kola-runext-rootless-systemd[1956]: Error: Failed to download metadata for repo 'fedora': Cannot prepare internal mirrorlist: Curl error (6): Couldn't resolve host name for https://mirrors.fedoraproject.org/metalink?repo=fedora-37&arch=x86_64 [getaddrinfo() thread failed to start]
Jan 30 16:48:36 qemu0 kola-runext-rootless-systemd[1904]: Error: error building at STEP "RUN dnf -y update && dnf -y install systemd httpd && dnf clean all && systemctl enable httpd": error while running runtime: exit status 1

Hmmm...that's usually from having an old container runtime that's still giving EPERM for clone()... It looks like things are a bit of a mess here, we have
containers-common-2:1-47.el9.x86_64 (appstream)
yet podman-3:4.2.0-4.rhaos4.12.el9.x86_64 (rhel-9.0-server-ose-4.13)?

@cgwalters
Copy link
Member

cgwalters commented Jan 30, 2023

Ohhh I see, we're just hitting https://bugzilla.redhat.com/show_bug.cgi?id=2123246 again now that it's missing from the denylist...

@cgwalters
Copy link
Member

cgwalters commented Jan 30, 2023

I'm piking up the ball ⚽ on this PR for the rest of the day.

@jlebon jlebon mentioned this pull request Jan 30, 2023
Closed
@jlebon
Copy link
Member

jlebon commented Jan 30, 2023

xref #1129 (comment)

@cgwalters
Copy link
Member

cgwalters commented Jan 30, 2023

OK, pushed a few test ignores/fixes.

@cgwalters
Copy link
Member

cgwalters commented Jan 30, 2023

Argh, same failures...but I'm not reproducing this locally? 😢

travier and others added 8 commits January 30, 2023 17:45
@cgwalters
Copy link
Member

cgwalters commented Jan 30, 2023

OK, finally figured out that the kola logs for the nonexclusive tests are in https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_os/1127/pull-ci-openshift-os-master-rhcos-90-build-test-qemu/1620159375001784320/artifacts/test/artifacts/kola/non-exclusive-test-bucket-0/4a597719-8ee2-4665-ac53-0eb383eefa04/ which helped.

I think I'm getting some yum repository config drift versus CI though, will try to dig into that tomorrow.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Member

cgwalters commented Jan 31, 2023 •
edited
Loading

OK we have green CI with some ignored tests. I think we should proceed in order to find the more important bugs, so adding /lgtm (insert obligatory Obama awarding self medal meme with repect to my additional commits). But also /hold - @travier if you agree with this please feel free to /hold cancel and let's move onto the next things to do here!
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@travier
Copy link
Member Author

travier commented Jan 31, 2023

LGTM
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6684ebe into openshift:master Jan 31, 2023
@travier travier deleted the rhel-9.2-variant branch January 31, 2023 16:51
@travier travier mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters approved these changes

@aaradhak aaradhak Awaiting requested review from aaradhak

@marmijo marmijo Awaiting requested review from marmijo

Assignees

@cgwalters cgwalters

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@travier @cgwalters @jlebon @openshift-merge-robot